Add metadata url to RocksDB #30
Merged
+211
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanChe
approved these changes
Jan 3, 2024
RequescoS
reviewed
Jan 3, 2024
|
|
||
| let number_of_tasks = tasks_buffer.len(); | ||
|
|
||
| if number_of_tasks > MAX_BUFFERED_TASKS_TO_TAKE { |
There was a problem hiding this comment.
Dont we need to check
if number_of_tasks + metadata_info.len() > MAX_BUFFERED_TASKS_TO_TAKE
here?
There was a problem hiding this comment.
Did you mean tasks_to_insert?
RequescoS
approved these changes
Jan 3, 2024
StanChe
reviewed
Jan 3, 2024
| if number_of_tasks + tasks_to_insert.len() > MAX_BUFFERED_TASKS_TO_TAKE { | ||
| tasks_to_insert.extend( | ||
| tasks_buffer | ||
| .drain(0..MAX_BUFFERED_TASKS_TO_TAKE - tasks_to_insert.len()) |
There was a problem hiding this comment.
What if the tasks_to_insert already holds more than max_buffered_tasks_to_take?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes insert metadata url to Postgre